Fix wasmExports declaration under MINIMAL_RUNTIME. NFC #20159
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Supersedes #20146 |
The declaration and definition of the wasmExports global were out of sync. One included EMBIND and the other didn't. I traced the original addition of EMBIND here back to #10417. At that point embind did depend on the `asm` global (now `wasmExports`) in order to do `asm['dynCall_' ..`. Nowadays MINIMAL_RUNTIME has a separate `dynCalls` globals where these live do the dyncall mechanism no longer depends on the `asm`/`wasmExports` global.
sbc100
force-pushed
the
fix_wasmExports
branch
from
2c2d17f to
7ad20fb
Compare
walkingeyerobot
approved these changes
Sep 6, 2023
kripken
approved these changes
Sep 6, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The declaration and definition of the wasmExports global were out of sync. One included EMBIND and the other didn't.
I traced the original addition of EMBIND here back to #10417. At that point embind did depend on the
asmglobal (nowwasmExports) in order to doasm['dynCall_' ... Nowadays MINIMAL_RUNTIME has a separatedynCallsglobals where these live do the dyncall mechanism no longerdepends on the
asm/wasmExportsglobal.Fixes: #20145