Deprecate EM_LOG_FUNC_PARAMS flag to emscripten_log/emscripten_get_callstack
#19820
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sbc100
force-pushed
the
deprecate_log_func_params
branch
from
197e803 to
f96dc74
Compare
sbc100
changed the title
EM_LOG_FUNC_PARAMS flag to emscripten_log/emscripten_get_…EM_LOG_FUNC_PARAMS flag to emscripten_log/emscripten_get_callstack
dschuff
reviewed
Jul 10, 2023
…callstack
Supporting this flag requires using `arguments.callee` which is
deprecated, and won't work if any of functions on the callstack are in
strict mode (or are arrow function, which implies strict mode).
Why any frame in the calling stack is in strict mode this call will
fail with:
```
TypeError: 'caller', 'callee', and 'arguments' properties may not be accessed on strict mode functions or the arguments objects for calls to them
at traverseStack (emscripten_log.js:941:30)
```
This effects of these flag seem to not actually be tested, even though
it is used in `test_emscripten_log`.
sbc100
force-pushed
the
deprecate_log_func_params
branch
from
f96dc74 to
fd02f94
Compare
|
Done |
dschuff
approved these changes
Jul 10, 2023
|
Side note, I don't think arrow functions imply strict mode. They do have different behavior of |
Ah yes you are right. But its not just |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Supporting this flag requires using
arguments.calleewhich is deprecated, and won't work if any of functions on the callstack are in strict mode (or are arrow function, which implies strict mode).The effect of these flag seem to not actually be tested, even though it is used in
test_emscripten_log.