-
Notifications
You must be signed in to change notification settings - Fork 3.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
document that clang-format may clobber javascript #19810
Conversation
tone_generator.c failed to compile after running through clang-format, because => changed to = >. clang-format can be disabled by putting comments around it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! Thats good to know.
I wonder if there is some way we can embed that in the macro itself? I would guess not.
Maybe! There's |
I found this while searching: https://clang.llvm.org/docs/ClangFormatStyleOptions.html#whitespacesensitivemacros
Maybe it would work, maybe not. |
Yes, I think that could work, but I think it also requires the modification of the Shall we just land this change as-is for now, and followup with a recommendation to use |
I added |
Great.. could you add that the doc too? And maybe add it to our |
tone_generator.c failed to compile after running through clang-format, because => changed to = >. clang-format can be disabled by putting comments around it.
I did not build this .rst file, just formatted it manually, so the formatting may have some errors.