document that clang-format may clobber javascript

[ad8e]

tone_generator.c failed to compile after running through clang-format, because => changed to = >. clang-format can be disabled by putting comments around it.

I did not build this .rst file, just formatted it manually, so the formatting may have some errors.

[sbc100]

Thanks! Thats good to know.

I wonder if there is some way we can embed that in the macro itself? I would guess not.

[ad8e]

Maybe! There's /* clang-format off */. That might fit somewhere in the macro. That would be a better solution if possible.

[ad8e]

I found this while searching: https://clang.llvm.org/docs/ClangFormatStyleOptions.html#whitespacesensitivemacros

WhitespaceSensitiveMacros (List of Strings)

    A vector of macros which are whitespace-sensitive and should not be touched.

    These are expected to be macros of the form:

    STRINGIZE(...)

Maybe it would work, maybe not.

[sbc100]

I found this while searching: https://clang.llvm.org/docs/ClangFormatStyleOptions.html#whitespacesensitivemacros

WhitespaceSensitiveMacros (List of Strings)

    A vector of macros which are whitespace-sensitive and should not be touched.

    These are expected to be macros of the form:

    STRINGIZE(...)

Maybe it would work, maybe not.

Yes, I think that could work, but I think it also requires the modification of the .clang-format file for each project containing EM_ASM.

Shall we just land this change as-is for now, and followup with a recommendation to use WhitespaceSensitiveMacros as well if that works (we should add it to the emscripten .clang-format if it does).

[ad8e]

I added WhitespaceSensitiveMacros: ['EM_ASM', 'EM_JS', 'EM_ASM_INT', 'EM_ASM_DOUBLE', 'EM_ASM_PTR', 'MAIN_THREAD_EM_ASM', 'MAIN_THREAD_EM_ASM_INT', 'MAIN_THREAD_EM_ASM_DOUBLE', 'MAIN_THREAD_EM_ASM_DOUBLE', 'MAIN_THREAD_ASYNC_EM_ASM'] to my .clang-format. Now the => survives, so this works. I like this more than needing to remember // clang-format off after every use.

[sbc100]

Great.. could you add that the doc too?

And maybe add it to our .clang-format here in this repo?