Skip to content

Fix mktime/timegm for time_t > MAX_INT32 #19700

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 23, 2023
Merged

Fix mktime/timegm for time_t > MAX_INT32 #19700

merged 1 commit into from
Jun 23, 2023

Conversation

sbc100
Copy link
Collaborator

@sbc100 sbc100 commented Jun 23, 2023

Fixes: #19694

@sbc100 sbc100 requested a review from kripken June 23, 2023 18:38
@sbc100 sbc100 force-pushed the avoid_pointer_arg branch from a31d107 to 98e3466 Compare June 23, 2023 18:50
@sbc100 sbc100 force-pushed the avoid_pointer_arg branch from 98e3466 to f01e545 Compare June 23, 2023 18:52
Base automatically changed from avoid_pointer_arg to main June 23, 2023 20:02
@sbc100 sbc100 merged commit 3ce924f into main Jun 23, 2023
@sbc100 sbc100 deleted the fix_gmtime_64 branch June 23, 2023 22:11
@riidefi riidefi mentioned this pull request Aug 16, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kripken kripken kripken approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

gmtime is still 32 bit (wrapping to 1900 after 2038)
2 participants
@sbc100 @kripken