Skip to content

[Wasm64] Get test_anisotropic passing with MEMORY64 #18971

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 3, 2023

Conversation

sbc100
Copy link
Collaborator

@sbc100 sbc100 commented Mar 15, 2023

This required fixing some basic SDL and OpenGL operations.

@sbc100
Copy link
Collaborator Author

sbc100 commented Mar 15, 2023

I'm trying to incrementally run more browser tests under MEMORY64.

Hopefully this doesn't overlap too much with #15433, it looks like it covers different parts of the GL codebase. @juj

@sbc100 sbc100 requested a review from kripken March 15, 2023 22:44
@sbc100 sbc100 changed the title [Wasm64] Get test_anisotropic with MEMORY64 [Wasm64] Get test_anisotropic passing with MEMORY64 Mar 15, 2023
@sbc100 sbc100 requested a review from juj March 15, 2023 23:21
This required fixing some basic SDL and OpenGL operations.
@sbc100 sbc100 force-pushed the test_anisotropic_wasm64 branch from 58bbbe2 to b0358bf Compare April 1, 2023 00:50
@sbc100 sbc100 requested a review from kripken April 1, 2023 00:51
@sbc100
Copy link
Collaborator Author

sbc100 commented Apr 1, 2023

Almost all the changes that were previously part of this PR have now landed via the automatic sig generations changes!

@sbc100
Copy link
Collaborator Author

sbc100 commented Apr 1, 2023

ptal

@sbc100 sbc100 merged commit f3c4c2a into main Apr 3, 2023
@sbc100 sbc100 deleted the test_anisotropic_wasm64 branch April 3, 2023 20:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants