Fix external usage of EM_JS functions #18928
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
In what sense is it still GC-able? I assume only LTO can do it? |
I mean that normal Basically wasm-ld will never see this pointer as being used so it won't allocate the 4-bytes to store it. |
sbc100
force-pushed
the
fix_em_js
branch
4 times, most recently
from
1c9679b to
f02d0cc
Compare
kripken
approved these changes
Mar 9, 2023
When no local usage of an EM_JS function is present the compiler was completely removing the import of the function (and its import_name). With this change we force at least one reference to the function by taking its address in an otherwise unused (and GC-able) pointer. This use case was broken by the switch to LLD_REPORT_UNDEFINED in #16003. Fixes: #18927
sbc100
changed the title
impact-maker
pushed a commit
to impact-maker/emscripten
that referenced
this pull request
Mar 17, 2023
When no local usage of an EM_JS function is present the compiler was completely removing the import of the function (and its import_name). With this change we force at least one reference to the function by taking its address in an otherwise unused (and GC-able) pointer. This use case was broken by the switch to LLD_REPORT_UNDEFINED in emscripten-core#16003. Fixes: emscripten-core#18927
impact-maker
pushed a commit
to impact-maker/emscripten
that referenced
this pull request
Mar 17, 2023
When no local usage of an EM_JS function is present the compiler was completely removing the import of the function (and its import_name). With this change we force at least one reference to the function by taking its address in an otherwise unused (and GC-able) pointer. This use case was broken by the switch to LLD_REPORT_UNDEFINED in emscripten-core#16003. Fixes: emscripten-core#18927
sbc100
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When no local usage of an EM_JS function is present the compiler was completely removing the import of the function (and its import_name).
With this change we force at least one reference to the function by taking its address in an otherwise unused (and GC-able) pointer.
This use case was broken by the switch to LLD_REPORT_UNDEFINED in #16003.
Fixes: #18927