Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

emscripten_condvar_wait returns EM_BOOL, not int. #18812

Merged
merged 1 commit into from
Feb 22, 2023
Merged

emscripten_condvar_wait returns EM_BOOL, not int. #18812

merged 1 commit into from
Feb 22, 2023

Conversation

waywardmonkeys
Copy link
Contributor

No description provided.

@waywardmonkeys
Copy link
Contributor Author

I noticed this when I was testing out trying to replace EM_BOOL with bool (and using <stdbool.h>).

sbc100
sbc100 approved these changes Feb 22, 2023
View reviewed changes
Copy link
Collaborator

@sbc100 sbc100 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

I would caution against including <stdbool.h> in our core headers though.. some user code out there might not want the names it introduced in their global scope (imagine code that defines its own true and false for macros for example).

@sbc100 sbc100 merged commit da0a1e9 into emscripten-core:main Feb 22, 2023
@waywardmonkeys waywardmonkeys deleted the condvar-wait-wrong-return-types branch January 21, 2024 04:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sbc100 sbc100 sbc100 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@waywardmonkeys @sbc100