Enable test_pthread_proxying_cpp on wasm2js #18360
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Dec 13, 2022
|
Current dependencies on/for this PR:
This comment was auto-generated by Graphite. |
It had previously been disabled because of flakes on wasm2js, but those flakes are probably fixed by #18358.
tlively
force-pushed
the
enable-proxying-test-wasm2js
branch
from
36d6d31 to
e9756cd
Compare
|
ping @sbc100 |
sbc100
approved these changes
Dec 19, 2022
|
Manually merging because the test failure is unrelated, but if we observe this flaking we should revert. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It had previously been disabled because of flakes on wasm2js, but those flakes
are probably fixed by #18358.