Skip to content

Extract startWorker helper. NFC #18313

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Dec 3, 2022
Merged

Extract startWorker helper. NFC #18313

merged 1 commit into from
Dec 3, 2022

Conversation

RReverser
Copy link
Collaborator

Extracted some changes out of #18305 that report Worker as ready only once runtime is initialized and Module variable is assigned.

@RReverser
Try to make Worker initialization less flaky
3935cdc 
Extracted some changes out of #18305 that report Worker as ready only once runtime is initialized *and* `Module` variable is assigned.

Want to see if it incidentally also helps with #18307.
@RReverser RReverser requested a review from sbc100 December 3, 2022 02:07
@RReverser RReverser mentioned this pull request Dec 3, 2022
Merged
sbc100
sbc100 approved these changes Dec 3, 2022
View reviewed changes
Copy link
Collaborator

@sbc100 sbc100 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah I see, we can't let closure minify this symbol because it needs to be shared between the worker.js and the main js file. If it was minified in the main js it wouldn't resolve correctly the implementation in the worker.

lgtm. Thanks for splitting this out.

@RReverser RReverser merged commit c93b3a1 into main Dec 3, 2022
@RReverser RReverser deleted the less-flaky-start-worker branch December 3, 2022 03:54
@merceyz merceyz mentioned this pull request Dec 10, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sbc100 sbc100 sbc100 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@RReverser @sbc100