Skip to content

Conversation

@tlively
Copy link
Member

@tlively tlively commented Sep 1, 2022

Update the return type of getSize from size_t to off_t, which allows for
negative error codes. off_t is more correct anyway, since in 32-bit mode
it is possible for a file size to be greater than the max value of size_t.
Also update the argument to getSize from size_t to off_t to match.

I manually verified that this error handling works with an injected error, but I
was not able to create a test that could trigger the error naturally.

Base automatically changed from wasmfs-flush-errors to main September 2, 2022 00:00
Update the return type of `getSize` from `size_t` to `off_t`, which allows for
negative error codes. `off_t` is more correct anyway, since in 32-bit mode
it is possible for a file size to be greater than the max value of `size_t`.
Also update the argument to `getSize` from `size_t` to `off_t` to match.

I manually verified that this error handling works with an injected error, but I
was not able to create a test that could trigger the error naturally.
@tlively
Copy link
Member Author

tlively commented Sep 2, 2022

The browser tests have failed 3 or 4 times in a row on this, but the problem is "too many unresponsive tests," so I think I have to just keep trying until they pass. I'll try running them all locally, too.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants