tentative changes for supporting memory64 in webgl wrapper #17743
Conversation
|
I have a work in progress PR #15433 that should address these JS library concerns. I should try to bring that up to latest. |
| @@ -69,7 +69,7 @@ var LibraryEGL = { | |||
| } else if (param == 0x3038 /*EGL_NONE*/) { | |||
| break; | |||
| } | |||
| attribList += 8; | |||
| attribList += 8n; | |||
There was a problem hiding this comment.
In general the way we avoid actually having to deal with BigInts in the JS libraries is to use __sig specifiers on the functions that receive the pointers. We use the p specifier within the signature to signify that a paramater or return type is a pointer or size_t value. For example a __sig of vpip would mean a void function that take a pointer, and integer, and another pointer. Then the library code will automatically convert pointers to JS numbers (int53 numbers to be precise) at the boundary.
There was a problem hiding this comment.
Ah, right, i think i did change the __sig of some other method in order to get this to work. I think there are a few places in the opengl code which use "i" instead of "p".
These changes are in no way production ready (most if this is hacked together in order to get a prototype build working). They have allowed me to generate a wasm64 compile of an opengl based rendering engine. These changes also provide the capability to use more than 4GB of heap memory when using the OpenGL api.