Simplify create_sending function. NFC #17189
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sbc100
force-pushed
the
simplify_create_sending
branch
from
0a7e6e2 to
0679afd
Compare
kripken
reviewed
Jun 9, 2022
| add_send_items(name, asmjs_mangle(name)) | ||
| for name in metadata['globalImports']: | ||
| # globalImports can currently overlap with declares, in the case of dynamic linking | ||
| add_send_items(name, asmjs_mangle(name), ignore_dups=settings.RELOCATABLE) |
There was a problem hiding this comment.
Before this PR we didn't have this check on RELOCATABLE, why is it needed now?
There was a problem hiding this comment.
Before this PR we were allowing duplication of the mangled names because we were doing send_items = set(invoke_funcs + declares + externs)
There was a problem hiding this comment.
So this change actually increases the strictness a little
There was a problem hiding this comment.
I'm not sure if we even need this check TBH
Rather than mangling all symbols and then trying to unmangle them again, just mangle the ones that actually need mangling. This allows the complete removal of the unmangling function.
sbc100
force-pushed
the
simplify_create_sending
branch
from
0679afd to
e996294
Compare
|
PTAL, I have another change that requires this one: #17153 |
kripken
approved these changes
Jun 9, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rather than mangling all symbols and then trying to unmangle them
again, just mangle the ones that actually need mangling.
This allows the complete removal of the unmangling function.