[wasm64] Fix (or skip) all core tests in wasm64l mode
#16922
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sbc100
changed the title
wasm64l mode
sbc100
force-pushed
the
wasm64_all_tests_pass
branch
2 times, most recently
from
2cc382f to
5af5613
Compare
Collaborator
Author
|
This PR seems pretty big so I'm thinking of splitting it up. |
sbc100
force-pushed
the
wasm64_all_tests_pass
branch
from
5af5613 to
1d63987
Compare
Member
|
+1 for splitting up, if that's not too much work. |
sbc100
force-pushed
the
wasm64_all_tests_pass
branch
3 times, most recently
from
d1797b3 to
d84a8ee
Compare
sbc100
added a commit
that referenced
this pull request
May 16, 2022
Move the instrumentWasmExportsForMemory64 helper out into its own file so we have be used under MINIMAL_RUNTIME too. In the long run this function should be replaced with something more data driven but for now this works. Split out from #16922
sbc100
added a commit
that referenced
this pull request
May 16, 2022
Move the instrumentWasmExportsForMemory64 helper out into its own file so we have be used under MINIMAL_RUNTIME too. In the long run this function should be replaced with something more data driven but for now this works. Split out from #16922
sbc100
added a commit
that referenced
this pull request
May 16, 2022
Move the instrumentWasmExportsForMemory64 helper out into its own file so we have be used under MINIMAL_RUNTIME too. In the long run this function should be replaced with something more data driven but for now this works. Split out from #16922
sbc100
added a commit
that referenced
this pull request
May 16, 2022
Move the instrumentWasmExportsForMemory64 helper out into its own file so we have be used under MINIMAL_RUNTIME too. In the long run this function should be replaced with something more data driven but for now this works. Split out from #16922
sbc100
added a commit
that referenced
this pull request
May 16, 2022
Move the instrumentWasmExportsForMemory64 helper out into its own file so we have be used under MINIMAL_RUNTIME too. In the long run this function should be replaced with something more data driven but for now this works. Split out from #16922
sbc100
added a commit
that referenced
this pull request
May 16, 2022
Move the instrumentWasmExportsForMemory64 helper out into its own file so we have be used under MINIMAL_RUNTIME too. In the long run this function should be replaced with something more data driven but for now this works. Split out from #16922
sbc100
force-pushed
the
wasm64_all_tests_pass
branch
from
9b88259 to
a6d9b9b
Compare
sbc100
changed the title
wasm64l modewasm64l mode
Collaborator
Author
|
The significant changes have now been split out and landed separately. PTAL |
sbc100
force-pushed
the
wasm64_all_tests_pass
branch
from
a6d9b9b to
1d0689a
Compare
kripken
reviewed
May 17, 2022
sbc100
force-pushed
the
wasm64_all_tests_pass
branch
2 times, most recently
from
4dbf302 to
db0fa92
Compare
sbc100
added a commit
that referenced
this pull request
May 18, 2022
This doesn't change the size of the type for wasm32 but helps with wasm64 since it makes these types consistent between the two. Split out from #16922
sbc100
added a commit
that referenced
this pull request
May 18, 2022
This doesn't change the size of the type for wasm32 but helps with wasm64 since it makes these types consistent between the two. Split out from #16922
sbc100
force-pushed
the
wasm64_all_tests_pass
branch
from
db0fa92 to
87ca65e
Compare
sbc100
added a commit
that referenced
this pull request
May 18, 2022
This doesn't change the size of the type for wasm32 but helps with wasm64 since it makes these types consistent between the two. Split out from #16922
kripken
reviewed
May 18, 2022
sbc100
added a commit
that referenced
this pull request
May 18, 2022
This doesn't change the size of the type for wasm32 but helps with wasm64 since it makes these types consistent between the two. Split out from #16922
sbc100
added a commit
that referenced
this pull request
May 18, 2022
This doesn't change the size of the type for wasm32 but helps with wasm64 since it makes these types consistent between the two. Split out from #16922
sbc100
added a commit
that referenced
this pull request
May 18, 2022
This doesn't change the size of the type for wasm32 but helps with wasm64 since it makes these types consistent between the two. Split out from #16922
sbc100
force-pushed
the
wasm64_all_tests_pass
branch
2 times, most recently
from
f4470dd to
0b013fd
Compare
Collaborator
Author
|
Feedback applied and rebased. We can leave EM_JS improvements as possible followups I think. |
This change contains a lot of fixes for wasm64 as well as a lot of disabling of classes of tests. Most significant changes have now been split out and landed separately.
sbc100
force-pushed
the
wasm64_all_tests_pass
branch
from
0b013fd to
8821c5f
Compare
sbc100
changed the title
wasm64l modewasm64l mode
kripken
approved these changes
May 19, 2022
sbc100
added a commit
that referenced
this pull request
May 19, 2022
Followup to #16922. The goal here is to do any BigInt/Number conversions for int53 at the JS/Wasm boundary. Some of the internal usage of `from64` predates the `__sig` machanism for annotating functions and no longer necessary.
sbc100
added a commit
that referenced
this pull request
May 19, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change contains a lot of fixes for wasm64 as well as a lot of
disabling of classes of tests. Most significant changes have now
been split out and landed separately.