Update pthread stub signatures #16682
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pthread_setcancelstate and pthread_setcanceltype previously did not have any arguments in library_pthread_stub.c. Fix them to take the proper arguments.
dschuff
approved these changes
Apr 8, 2022
Member
|
LGTM, I'm just going to merge this. |
sbc100
reviewed
Apr 12, 2022
| return 0; | ||
| } | ||
|
|
||
| int pthread_setcancelstate() { |
Collaborator
There was a problem hiding this comment.
Why did the compiler allow this in the first place? Are we missing a header in include here?
Member
Author
There was a problem hiding this comment.
In C prior to C23, this is K&R-style function definition since it is missing void in the parameter location. Which I guess means it matches with any declaration? It's kind of weird because I would have expected the non-K&R declaration to force the definition to have the proper type, but idk exactly how this works.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
pthread_setcancelstate and pthread_setcanceltype previously did not have any
arguments in library_pthread_stub.c. Fix them to take the proper arguments.