Skip to content

[WASMFS] JS File Backend Structure #15562

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 24 commits into from
Nov 24, 2021
Merged

Conversation

ethanalee
Copy link
Collaborator

Relevant Issue: #15041

Tentative JS File Backend Structure

  • Introduced user-visible header file.
  • Users can create a new JS Backend and create JS Backed Files under both In-Memory and JS Backend directories.

@ethanalee ethanalee changed the base branch from main to wamsfs-modular-backend-memoryfile November 18, 2021 17:32
@ethanalee ethanalee force-pushed the wasmfs-modular-backend-jsbackend branch 3 times, most recently from e7c1dc1 to a3635e8 Compare November 18, 2021 17:50
@ethanalee ethanalee force-pushed the wamsfs-modular-backend-memoryfile branch from 49a000f to 6545516 Compare November 18, 2021 22:18
@ethanalee ethanalee requested review from tlively and kripken November 18, 2021 22:38
Base automatically changed from wamsfs-modular-backend-memoryfile to main November 19, 2021 20:44
@ethanalee ethanalee force-pushed the wasmfs-modular-backend-jsbackend branch 2 times, most recently from df20662 to 196a036 Compare November 22, 2021 22:00
@ethanalee ethanalee requested review from kripken and tlively November 22, 2021 22:15
@ethanalee ethanalee force-pushed the wasmfs-modular-backend-jsbackend branch from 2163f73 to 169ad29 Compare November 22, 2021 23:18
@ethanalee ethanalee requested a review from kripken November 22, 2021 23:19
@ethanalee ethanalee force-pushed the wasmfs-modular-backend-jsbackend branch from 4596e35 to 303172f Compare November 23, 2021 07:43
Copy link
Member

@tlively tlively left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice job with how you factored doOpen and doMkdir 👍

LGTM modulo those small comments.

Copy link
Member

@kripken kripken left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice progress, mostly lgtm aside from these comments.

Copy link
Member

@kripken kripken left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm % last comments

@ethanalee ethanalee enabled auto-merge (squash) November 24, 2021 04:40
@ethanalee ethanalee merged commit 7e6d511 into main Nov 24, 2021
@ethanalee ethanalee deleted the wasmfs-modular-backend-jsbackend branch November 24, 2021 05:38
mmarczell-graphisoft pushed a commit to GRAPHISOFT/emscripten that referenced this pull request Jan 5, 2022
Relevant Issue: emscripten-core#15041

Tentative JS File Backend Structure

Introduced user-visible header file.
Users can create a new JS Backend and create JS Backed Files under both In-Memory and JS Backend directories.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants