-
Notifications
You must be signed in to change notification settings - Fork 3.4k
[WASMFS] JS File Backend Structure #15562
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
…backend-jsbackend
…backend-jsbackend
e7c1dc1
to
a3635e8
Compare
49a000f
to
6545516
Compare
df20662
to
196a036
Compare
2163f73
to
169ad29
Compare
4596e35
to
303172f
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice job with how you factored doOpen
and doMkdir
👍
LGTM modulo those small comments.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice progress, mostly lgtm aside from these comments.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm % last comments
Relevant Issue: emscripten-core#15041 Tentative JS File Backend Structure Introduced user-visible header file. Users can create a new JS Backend and create JS Backed Files under both In-Memory and JS Backend directories.
Relevant Issue: #15041
Tentative JS File Backend Structure