Add some new musl math files to libc-rt library #15497
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We have had reports of missing symbols in LTO builds after the musl upgrade (#13006): https://groups.google.com/g/emscripten-discuss/c/g_vkRRSCPUI/m/aT6fnUAtCQAJ?utm_medium=email&utm_source=footer Also `lto2.test_float_builtinsTest` started failing on the emscripten-releases FYI waterfall. This change moves some of the new math-related source files into the libc-mt library which is excluded from LTO (see comments in in system_libs.py for background on this). Fixes: #15506
|
Enabling auto-merge. I"m going to be OOO for a few hours but hopefully this can get landed ASAP so folks who are testing |
|
Would be nice to get the following files into the PR before it's merged: __math_invalid.c, __math_invalidf.c', __math_invalidl.c See: |
kripken
approved these changes
Nov 12, 2021
|
Looks like the last 3 files didn't make it? I'll raise the issue again when the tot SDK has been updated :) |
|
Oops, sorry, will open another PR |
sbc100
added a commit
that referenced
this pull request
Nov 12, 2021
sbc100
added a commit
that referenced
this pull request
Nov 12, 2021
|
Everything working now on my side. Thanks! |
mmarczell-graphisoft
pushed a commit
to GRAPHISOFT/emscripten
that referenced
this pull request
Jan 5, 2022
We have had reports of missing symbols in LTO builds after the musl upgrade (emscripten-core#13006): https://groups.google.com/g/emscripten-discuss/c/g_vkRRSCPUI/m/aT6fnUAtCQAJ?utm_medium=email&utm_source=footer Also `lto2.test_float_builtinsTest` started failing on the emscripten-releases FYI waterfall. This change moves some of the new math-related source files into the libc-mt library which is excluded from LTO (see comments in in system_libs.py for background on this). Fixes: emscripten-core#15506
mmarczell-graphisoft
pushed a commit
to GRAPHISOFT/emscripten
that referenced
this pull request
Jan 5, 2022
sbc100
added a commit
that referenced
this pull request
Sep 8, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We had some reports of missing symbols in LTO builds after
the musl upgrade (#13006):
https://groups.google.com/g/emscripten-discuss/c/g_vkRRSCPUI/m/aT6fnUAtCQAJ?utm_medium=email&utm_source=footer
This change moves some of the new math-related source files
into the libc-mt library which is excluded from LTO (see comments
in in system_libs.py for background on this).
Verified that
lto2.test_float_builtinsTestnow passes with thischange but fails without (after musl upgrade).
This change fixes
asan.test_float_builtinsthat is currentlyfailing. See #15498.