Fix flakiness in test_pthread_c11_threads #15178
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sbc100
force-pushed
the
fix_flakey_test
branch
from
800acba to
ff99d94
Compare
sbc100
changed the title
sbc100
changed the title
I tracked down this issue to a deadlock between the detached thread calling `printf()` (calling proxied write call while hold the stdout lock) and the main thread trying to shut down the runtime by (calling `fflush(0`)). The problem could be addressed if we allowed nested calls to `emscripten_current_thread_process_queued_calls`. Fixes: #14579
sbc100
force-pushed
the
fix_flakey_test
branch
from
ff99d94 to
a2fd1bc
Compare
kripken
approved these changes
Sep 29, 2021
Co-authored-by: Alon Zakai <azakai@google.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I tracked down this issue to a deadlock between the detached thread
calling
printf()(calling proxied write call while hold the stdoutlock) and the main thread trying to shut down the runtime by (calling
fflush(0)).The problem could be addressed if we allowed nested calls to
emscripten_current_thread_process_queued_calls.Fixes: #14579