Don't mark a thread as joinable when it calls exit() #15105
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sbc100
force-pushed
the
no_joinable_on_exit
branch
5 times, most recently
from
0c83f1e to
26cfbc7
Compare
sbc100
changed the title
sbc100
force-pushed
the
no_joinable_on_exit
branch
3 times, most recently
from
ffa6a45 to
d38cde3
Compare
kleisauke
reviewed
Sep 23, 2021
sbc100
force-pushed
the
no_joinable_on_exit
branch
2 times, most recently
from
d1342d6 to
ca5b941
Compare
kleisauke
approved these changes
Sep 23, 2021
src/library_pthread.js
Outdated
Comment on lines
1239
to
1253
| $exitProcess__deps: ['$handleException', 'exit'], | ||
| $exitProcess__deps: ['exit', |
There was a problem hiding this comment.
The $exitProcess__deps line is duplicated now with different array values (probably the latter takes precedence over the former).
sbc100
force-pushed
the
no_joinable_on_exit
branch
from
ca5b941 to
3dddeb6
Compare
sbc100
force-pushed
the
no_joinable_on_exit
branch
3 times, most recently
from
80e2ad2 to
357454e
Compare
The previous behavior was that ExitStatus was thrown which ends up calling emscripten_thread_exit and marking the current thread as join-able. This this bug was masking several failures in the posixtest suite which have always be failing but were not being recognized as such. Note that we have to use the message queue rather than postMessage to deliver the `exitProcess` message since postMessage will not interrupt the main thread if its blocking on pthread_join. Modify the existing test so that it fails if pthead_join even returns. Fixes: #14993
sbc100
force-pushed
the
no_joinable_on_exit
branch
from
357454e to
ea78e10
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The previous behavior was that ExitStatus was thrown which ends up
calling emscripten_thread_exit and marking the current thread as
joinable.
This this bug was masking several failures in the posixtest suite
which have always be failing but were not being recognised as such.
Note that we have to use the message queue rather than postMessage
to deliver the exitProcess message since postMessage will not interrupt
the main thread if its blocking on pthread_join.
Modify the existing test so that it fails if pthead_join even returns.
The tests that were passing before are basically of the form:
Such a program would return 0 without this fix.
Fixes: #14993