Skip to content

Keep runtime alive while async ccall is running #15085

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 21, 2021

Conversation

sbc100
Copy link
Collaborator

@sbc100 sbc100 commented Sep 21, 2021

Without this, when EXIT_RUNTIME is set, the runtime will exit when when we return the event loop.

@sbc100 sbc100 requested review from kripken and RReverser September 21, 2021 21:04
@sbc100 sbc100 force-pushed the async_ccall_runtime_keepalive branch from e682e32 to 4b45323 Compare September 21, 2021 21:09
@sbc100 sbc100 enabled auto-merge (squash) September 21, 2021 21:09
Copy link
Member

@kripken kripken left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm % comment

How are tests passing given , is not a valid character in a test name? Is it just skipping invalid names silently..?

@sbc100
Copy link
Collaborator Author

sbc100 commented Sep 21, 2021

lgtm % comment

How are tests passing given , is not a valid character in a test name? Is it just skipping invalid names silently..?

I guess you can pragmatically create functions with arbitrary names like that. The test certainly runs:

$ ./tests/runner wasm2.test_async_ccall_promise*
Test suites:
['test_core']
Running test_core: (2 tests)
Using 2 parallel test processes
test_async_ccall_promise_exit_runti,e (test_core.wasm2) ... ok (1.65s)
test_async_ccall_promise (test_core.wasm2) ... ok (1.73s)

1 similar comment
@sbc100
Copy link
Collaborator Author

sbc100 commented Sep 21, 2021

lgtm % comment

How are tests passing given , is not a valid character in a test name? Is it just skipping invalid names silently..?

I guess you can pragmatically create functions with arbitrary names like that. The test certainly runs:

$ ./tests/runner wasm2.test_async_ccall_promise*
Test suites:
['test_core']
Running test_core: (2 tests)
Using 2 parallel test processes
test_async_ccall_promise_exit_runti,e (test_core.wasm2) ... ok (1.65s)
test_async_ccall_promise (test_core.wasm2) ... ok (1.73s)

@sbc100 sbc100 disabled auto-merge September 21, 2021 21:58
@sbc100 sbc100 force-pushed the async_ccall_runtime_keepalive branch from 4b45323 to 62d31dc Compare September 21, 2021 21:59
@sbc100 sbc100 merged commit 6b53ded into main Sep 21, 2021
@sbc100 sbc100 deleted the async_ccall_runtime_keepalive branch September 21, 2021 22:07
@kripken
Copy link
Member

kripken commented Sep 21, 2021

Oh wow, how flexible of python to allow such names... neat.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants