[tests] Improve dylink_testf. NFC #14992
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sbc100
force-pushed
the
dylink_testf
branch
2 times, most recently
from
b056f92 to
089b3df
Compare
Using the default for side module and output filename mean call sites don't need so much boilerplate.
aheejin
approved these changes
Sep 2, 2021
| @@ -4579,9 +4581,7 @@ def test_dylink_argv_argc(self): | |||
| def test_dylink_weak(self): | |||
| # Verify that weakly defined symbols can be defined in both side module and main | |||
| # module but that only one gets used at runtime. | |||
| main = test_file('core/test_dylink_weak_main.c') | |||
| side = test_file('core/test_dylink_weak_side.c') | |||
| self.dylink_testf(main, side, force_c=True, need_reverse=False) | |||
There was a problem hiding this comment.
force_c=True was deleted in the RHS.. Is this intended?
There was a problem hiding this comment.
Yes, force_c is only needed when the filename is not specified. In this case it doesn't do anything.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Using the default for side module and output filename
mean call sites don't need so much boilerplate.