Add signature of gettimeofday js library function#14969
Merged
sbc100 merged 2 commits intoemscripten-core:mainfrom Aug 31, 2021
ravisumit33:main
Merged
Add signature of gettimeofday js library function#14969sbc100 merged 2 commits intoemscripten-core:mainfrom ravisumit33:main
sbc100 merged 2 commits intoemscripten-core:mainfrom
ravisumit33:main
Conversation
|
Thank you for submitting a pull request! Someone will be along to review it shortly. |
Contributor
Author
|
@sbc100 Please review |
sbc100
reviewed
Aug 30, 2021
src/library.js
Outdated
| if (clk_id) {{{ makeSetValue('clk_id', 0, 2/*CLOCK_PROCESS_CPUTIME_ID*/, 'i32') }}}; | ||
| return 0; | ||
| }, | ||
| gettimeofday__sig: 'ii', |
Collaborator
There was a problem hiding this comment.
I think the sig of this function is iii (return an int and takes 2 pointers).
Contributor
Author
There was a problem hiding this comment.
May be I am wrong, but I can see only one argument ptr in the function gettimeofday (here)
Collaborator
There was a problem hiding this comment.
It take a second argument which is the timezone (which this version currently completely ignores I guess): https://man7.org/linux/man-pages/man2/settimeofday.2.html.
sbc100
approved these changes
Aug 30, 2021
Contributor
Author
|
@sbc100 Failing test shows context deadline exceeded. Any idea what can cause that ? |
Collaborator
|
That's test flakiness, I restarted the test run. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes: #14959