Move thread exit code to native. NFC #14853
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kripken
reviewed
Aug 12, 2021
system/lib/pthread/pthread_create.c
Outdated
|
|
||
| // Mark the thread as no longer running. | ||
| // When we publish this, the main thread is free to deallocate the thread object and we are done. | ||
| // Therefore set _pthread_self = 0; above to 'release' the object in this worker thread. |
There was a problem hiding this comment.
Where is the thing this comment mentions done?
There was a problem hiding this comment.
I think this is referring to the _emscripten_thread_init below. The comment is just copied directly and equally inaccurate before this change.
There was a problem hiding this comment.
I just removed this line since _emscripten_thread_init is already commented below.
kripken
approved these changes
Aug 12, 2021
thyrrestrup
pushed a commit
to thyrrestrup/emscripten
that referenced
this pull request
Aug 18, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.