Ensure pthread key dtors run on main thread too

[sbc100]

No description provided.

[kleisauke]

I just noticed that the destructor function in test_pthread_setspecific_mainthread.c is never called when testing this on Linux. According to https://stackoverflow.com/a/6357265 pthread key dtors are only run when a thread exits (or when pthread_exit is explicitly called), so not on application exit (i.e. when the main thread exits). Sorry for not catching this earlier.

I could fix this in PR #13007 with commit dce4aa0, but let me know if a separate PR is preferred rather than deferring this to the upcoming musl upgrade.

[sbc100]

I just noticed that the destructor function in test_pthread_setspecific_mainthread.c is never called when testing this on Linux. According to https://stackoverflow.com/a/6357265 pthread key dtors are only run when a thread exits (or when pthread_exit is explicitly called), so not on application exit (i.e. when the main thread exits). Sorry for not catching this earlier.

I could fix this in PR #13007 with commit dce4aa0, but let me know if a separate PR is preferred rather than deferring this to the upcoming musl upgrade.

Thanks for noticing that! I would love to see that commit land as its own PR. In general, I'm always a fan of splitting out each and every commit/change in separate PRs.

[sbc100]

BTW I'm really focused on getting the musl upgrade done in the next week or so... I'm hopeful :)

[kleisauke]

A pull request has been made for this at #14751.

BTW I'm really focused on getting the musl upgrade done in the next week or so... I'm hopeful :)

Thanks for continuing to work on the musl upgrade!