Skip to content

Use _Exit and _exit from musl source. NFC #14464

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 17, 2021
Merged

Use _Exit and _exit from musl source. NFC #14464

merged 1 commit into from
Jun 17, 2021

Conversation

sbc100
Copy link
Collaborator

@sbc100 sbc100 commented Jun 16, 2021

This is part 1 of a change I'm working on to use musl's exit code. This
is NFC because we endup calling proc_exit which calls exit in any case.

@sbc100 sbc100 force-pushed the use_musl_exit_part1 branch from 565e9da to fc5f81b Compare June 16, 2021 20:05
@sbc100 sbc100 requested a review from kripken June 16, 2021 20:06
kripken
kripken approved these changes Jun 16, 2021
View reviewed changes
Copy link
Member

@kripken kripken left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@sbc100 sbc100 enabled auto-merge (squash) June 16, 2021 21:16
@sbc100 sbc100 force-pushed the use_musl_exit_part1 branch 4 times, most recently from b5a50ef to 1d70d1c Compare June 17, 2021 01:27
@sbc100
Use _Exit and _exit from musl source. NFC
a05d712 
This is part 1 of a change I'm working on to use musl's exit code.  This
is NFC because we endup calling proc_exit which calls exit in any case.
@sbc100 sbc100 force-pushed the use_musl_exit_part1 branch from 1d70d1c to a05d712 Compare June 17, 2021 17:57
@sbc100 sbc100 merged commit b1d2d39 into main Jun 17, 2021
@sbc100 sbc100 deleted the use_musl_exit_part1 branch June 17, 2021 18:51
sbc100 added a commit that referenced this pull request Jun 18, 2021
@sbc100
Use musl version of exit handling code
3aee855 
Followup to #14464, we now use atexit and exit
and other functions from musl.
@sbc100 sbc100 mentioned this pull request Jun 18, 2021
Open
sbc100 added a commit that referenced this pull request Jun 18, 2021
@sbc100
Use musl version of exit handling code
c7feb69 
Followup to #14464, we now use atexit and exit
and other functions from musl.
sbc100 added a commit that referenced this pull request Jun 18, 2021
@sbc100
Use musl version of exit handling code
26ae624 
Followup to #14464, we now use atexit and exit
and other functions from musl.
sbc100 added a commit that referenced this pull request Jun 19, 2021
@sbc100
Move __cxa_thread_atexit to native code
de8c554 
Rather than using a separate JS array use pthread TLS key which get
cleaned during `__pthread_tsd_run_dtors`.

Followup to #14484 and #14464 which both move more of the cleanup
handling for threads and processes onto the native side.
@sbc100 sbc100 mentioned this pull request Jun 19, 2021
Merged
sbc100 added a commit that referenced this pull request Jun 19, 2021
@sbc100
Move __cxa_thread_atexit to native code
e338f1f 
Rather than using a separate JS array use pthread TLS key which get
cleaned during `__pthread_tsd_run_dtors`.

Followup to #14484 and #14464 which both move more of the cleanup
handling for threads and processes onto the native side.
sbc100 added a commit that referenced this pull request Jun 19, 2021
@sbc100
Move __cxa_thread_atexit to native code
a6a9edc 
Rather than using a separate JS array use pthread TLS key which get
cleaned during `__pthread_tsd_run_dtors`.

Followup to #14484 and #14464 which both move more of the cleanup
handling for threads and processes onto the native side.
sbc100 added a commit that referenced this pull request Jun 22, 2021
@sbc100
Move __cxa_thread_atexit to native code
11fbd46 
Rather than using a separate JS array use pthread TLS key which get
cleaned during `__pthread_tsd_run_dtors`.

Followup to #14484 and #14464 which both move more of the cleanup
handling for threads and processes onto the native side.
sbc100 added a commit that referenced this pull request Jun 22, 2021
@sbc100
Move __cxa_thread_atexit to native code
3c9eb7b 
Rather than using a separate JS array use pthread TLS key which get
cleaned during `__pthread_tsd_run_dtors`.

Followup to #14484 and #14464 which both move more of the cleanup
handling for threads and processes onto the native side.
sbc100 added a commit that referenced this pull request Jun 23, 2021
@sbc100
Move __cxa_thread_atexit to native code
1bdace4 
Rather than using a separate JS array use pthread TLS key which get
cleaned during `__pthread_tsd_run_dtors`.

Followup to #14484 and #14464 which both move more of the cleanup
handling for threads and processes onto the native side.
sbc100 added a commit that referenced this pull request Jun 23, 2021
@sbc100
Move __cxa_thread_atexit to native code
07edd79 
Rather than using a separate JS array use pthread TLS key which get
cleaned during `__pthread_tsd_run_dtors`.

Followup to #14484 and #14464 which both move more of the cleanup
handling for threads and processes onto the native side.
sbc100 added a commit that referenced this pull request Jun 28, 2021
@sbc100
Move __cxa_thread_atexit to native code
7e96e04 
Rather than using a separate JS array use pthread TLS key which get
cleaned during `__pthread_tsd_run_dtors`.

Followup to #14484 and #14464 which both move more of the cleanup
handling for threads and processes onto the native side.
sbc100 added a commit that referenced this pull request Jun 29, 2021
@sbc100
Move __cxa_thread_atexit to native code
d47447c 
Rather than using a separate JS array use pthread TLS key which get
cleaned during `__pthread_tsd_run_dtors`.

Followup to #14484 and #14464 which both move more of the cleanup
handling for threads and processes onto the native side.
sbc100 added a commit that referenced this pull request Jun 30, 2021
@sbc100
Move __cxa_thread_atexit to native code
eae80e0 
Rather than using a separate JS array use pthread TLS key which get
cleaned during `__pthread_tsd_run_dtors`.

Followup to #14484 and #14464 which both move more of the cleanup
handling for threads and processes onto the native side.
sbc100 added a commit that referenced this pull request Oct 4, 2021
@sbc100
Move __cxa_thread_atexit to native code
9f49acf 
Rather than using a separate JS array use pthread TLS key which get
cleaned during `__pthread_tsd_run_dtors`.

Followup to #14484 and #14464 which both move more of the cleanup
handling for threads and processes onto the native side.
sbc100 added a commit that referenced this pull request Oct 4, 2021
@sbc100
Move __cxa_thread_atexit to native code
0fb0306 
Rather than using a separate JS array use pthread TLS key which get
cleaned during `__pthread_tsd_run_dtors`.

Followup to #14484 and #14464 which both move more of the cleanup
handling for threads and processes onto the native side.
sbc100 added a commit that referenced this pull request Oct 4, 2021
@sbc100
Move __cxa_thread_atexit to native code
179ecd2 
Rather than using a separate JS array use pthread TLS key which get
cleaned during `__pthread_tsd_run_dtors`.

Followup to #14484 and #14464 which both move more of the cleanup
handling for threads and processes onto the native side.
sbc100 added a commit that referenced this pull request Oct 4, 2021
@sbc100
Move __cxa_thread_atexit to native code
5af35f2 
Rather than using a separate JS array use pthread TLS key which get
cleaned during `__pthread_tsd_run_dtors`.

Followup to #14484 and #14464 which both move more of the cleanup
handling for threads and processes onto the native side.
sbc100 added a commit that referenced this pull request Oct 4, 2021
@sbc100
Move __cxa_thread_atexit to native code
48d0d34 
Rather than using a separate JS array use pthread TLS key which get
cleaned during `__pthread_tsd_run_dtors`.

Followup to #14484 and #14464 which both move more of the cleanup
handling for threads and processes onto the native side.
sbc100 added a commit that referenced this pull request Oct 4, 2021
@sbc100
Move __cxa_thread_atexit to native code
272673b 
Rather than using a separate JS array use pthread TLS key which get
cleaned during `__pthread_tsd_run_dtors`.

Followup to #14484 and #14464 which both move more of the cleanup
handling for threads and processes onto the native side.
sbc100 added a commit that referenced this pull request Oct 4, 2021
@sbc100
Move __cxa_thread_atexit to native code (#14489)
b55a3c3 
Use libc++abi's version of __cxa_thread_atexit.

Followup to #14484 and #14464 which both move more of the cleanup
handling for threads and processes onto the native side.

Depends on #15210.
sbc100 added a commit that referenced this pull request Aug 12, 2022
@sbc100
Move __cxa_thread_atexit to native code
c3f5cf5 
Rather than using a separate JS array use pthread TLS key which get
cleaned during `__pthread_tsd_run_dtors`.

Followup to #14484 and #14464 which both move more of the cleanup
handling for threads and processes onto the native side.
sbc100 added a commit that referenced this pull request Aug 12, 2022
@sbc100
Use musl version of exit handling code
959491b 
Followup to #14464, we now use atexit and exit
and other functions from musl.
sbc100 added a commit that referenced this pull request Jan 3, 2025
@sbc100
Use musl version of exit handling code
47457b2 
Followup to #14464, we now use atexit and exit
and other functions from musl.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kripken kripken kripken approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sbc100 @kripken