Do not require ENVIRONMENT=node,worker for node+pthreads #14151
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ohh that sounds like a great idea - fewer errors that tell you to enable options, and more of just doing the right thing where it's already unambiguous is definitely a DX improvement. |
RReverser
approved these changes
May 11, 2021
RReverser
added a commit
to RReverser/emscripten
that referenced
this pull request
Jun 9, 2025
- Similar to emscripten-core#14151 but for more combos. - Fixes emscripten-core#14162.
RReverser
added a commit
to RReverser/emscripten
that referenced
this pull request
Jun 9, 2025
- Similar to emscripten-core#14151 but for more combos. - Fixes emscripten-core#14162.
RReverser
added a commit
that referenced
this pull request
Jun 10, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allow just setting
ENVIRONMENT=nodein combination with pthreads, asthat is unambiguous, and should not be broken.
Perhaps we should do the same with pthreads outside of node, however
because of the node support code it is trivial to do it in node. I suspect it
would be more work otherwise.
Fixes #14134
cc @RReverser