Rename settings_key_changes to settings_map and reuse it apply_settings. NFC #13743
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sbc100
force-pushed
the
settings_key_changes_part2
branch
2 times, most recently
from
0fc1347 to
3c819b0
Compare
aheejin
approved these changes
Mar 23, 2021
sbc100
force-pushed
the
settings_key_changes_part2
branch
from
3c819b0 to
847b4ed
Compare
sbc100
added a commit
that referenced
this pull request
Mar 23, 2021
sbc100
added a commit
that referenced
this pull request
Mar 23, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.