Extend test_exceptions_allowed to include wasm. NFC #13734
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Parts of the test were previously disabled under wasm but it turns out the assertions all hold under wasm too.
aheejin
approved these changes
Mar 22, 2021
sbc100
force-pushed
the
update_test_exceptions_allowed
branch
from
dfa67e3 to
168149f
Compare
|
It seems it is not satisfied on wasm3? I disabled the auto-merge. |
Fixed to include wasm size. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Parts of the test were previously disabled under wasm
but it turns out the assertions all hold under wasm too.