Skip to content

wasm2c: abort=>trap #13718

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 22, 2021
Merged

wasm2c: abort=>trap #13718

merged 1 commit into from
Mar 22, 2021

Conversation

kripken
Copy link
Member

@kripken kripken commented Mar 19, 2021

abort() would affect the entire outside program. Instead, trap, so the
outside can handle it if it wants.

We call this method on bad errors, but they are still bad errors inside
the sandbox, so the outside can destroy the sandbox and forget about
it.

@kripken kripken requested a review from sbc100 March 19, 2021 22:15
@kripken kripken merged commit 4ce8967 into main Mar 22, 2021
@kripken kripken deleted the wasm2ctrap branch March 22, 2021 23:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants