Use a specific lock file to avoid temp directory contention #13371
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sbc100
force-pushed
the
avoid_cache_lock
branch
from
2dc9774 to
8c3d63e
Compare
sbc100
force-pushed
the
avoid_cache_lock
branch
from
8c3d63e to
514871d
Compare
|
This change is needed in order to unblock the emsdk bump (current blocked on bazel and #13369) |
kripken
approved these changes
Jan 29, 2021
| # In the case where we run emcc recurively to populate the cache we | ||
| # do still need to ignore this lock, in the same way we do for the cache | ||
| # lock. | ||
| if 'EM_EXCLUSIVE_CACHE_ACCESS' not in os.environ: |
There was a problem hiding this comment.
it is a little unfortunate to mention EM_EXCLUSIVE_CACHE_ACCESS here as it would be the first time outside of cache.py. Perhaps we could call a helper function in that file?
There was a problem hiding this comment.
It is a little sad that need this exception here.. but I'm OK with hardcoding it for now. Hopefully in the long run we can completely remove EM_EXCLUSIVE_CACHE_ACCESS.
Previously in debug mode we could try to avoid temp file contension by taking and holding the cache lock for the duration of the process. This change uses a specific lock file within the temp directory which avoid needing a writable cache directory. Its also more logical. Partial fix for #13369
sbc100
force-pushed
the
avoid_cache_lock
branch
from
514871d to
ffa824a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously in debug mode we could try to avoid temp file contension by
taking and holding the cache lock for the duration of the process.
This change uses a specific lock file within the temp directory which
avoids needing a writable cache directory. Its also more logical.
Partial fix for #13369