Error on bad JS library elements #12673
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For libary config element such as `foo__sig` error out if the corresponding library member is not found (in this case if `foo` is not in the library. This found `memcpy__inline` which can be removed since memcpy is no longer part of the JS library. Also remove `__inline` completely since this was the last use of it, and its asmjs specific.
kripken
approved these changes
Nov 2, 2020
tests/test_other.py
Outdated
| @@ -9578,6 +9578,17 @@ def test_jslib_clobber_i(self): | |||
| '--js-library=lib1.js', | |||
| '--js-library=lib2.js']) | |||
|
|
|||
| def test_jslib_bad_config(self): | |||
| # Regression check for an issue we have where a library clobbering the global `i` variable could | |||
| # prevent processing of further libraries. | |||
There was a problem hiding this comment.
this comment looks copy-pasted and inaccurate?
|
Yes this change does effectively get rid of |
brendandahl
added a commit
to brendandahl/emscripten
that referenced
this pull request
Feb 6, 2025
Looks like this was removed in emscripten-core#12673
brendandahl
added a commit
that referenced
this pull request
May 8, 2025
Looks like this was removed in #12673
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For libary config element such as
foo__sigerror out ifthe corresponding library member is not found (in this
case if
foois not in the library.This found
memcpy__inlinewhich can be removed sincememcpy is no longer part of the JS library.
Also remove
__inlinecompletely since this was the lastuse of it, and its asmjs specific.