Fix comment indentation to match code. #10916
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kripken
reviewed
Apr 14, 2020
| // TODO: Due to Closure regression https://github.com/google/closure-compiler/issues/3193, the above line no longer optimizes out down to the following line. | ||
| // When the regression is fixed, can restore the above USE_PTHREADS-enabled path. | ||
| // TODO: Due to Closure regression https://github.com/google/closure-compiler/issues/3193, the above line no longer optimizes out down to the following line. | ||
| // When the regression is fixed, can restore the above USE_PTHREADS-enabled path. | ||
| receiveInstance(output['instance']); |
There was a problem hiding this comment.
hmm, this still doesn't look aligned? (992 vs 993)
kripken
reviewed
Apr 14, 2020
src/preamble.js
Outdated
Comment on lines
991
to
992
| // TODO: Due to Closure regression https://github.com/google/closure-compiler/issues/3193, the above line no longer optimizes out down to the following line. | ||
| // When the regression is fixed, can restore the above USE_PTHREADS-enabled path. |
There was a problem hiding this comment.
Suggested change
| // TODO: Due to Closure regression https://github.com/google/closure-compiler/issues/3193, the above line no longer optimizes out down to the following line. | |
| // When the regression is fixed, can restore the above USE_PTHREADS-enabled path. | |
| // TODO: Due to Closure regression https://github.com/google/closure-compiler/issues/3193, the above line no longer optimizes out down to the following line. | |
| // When the regression is fixed, can restore the above USE_PTHREADS-enabled path. |
waywardmonkeys
force-pushed
the
fix-indenting
branch
from
fbd3952
to
af64bae
Compare
|
Sorry about missing that. Updated the branch. |
kripken
approved these changes
Apr 15, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.