Remove old files from musl source tree #10492
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When musl was updated to version 1.1.5 in #4813 it looks like files that were removed upstream were not removed locally. Because we recursively build some directories this means we were build old files. For example the src/locale/is*.c family of functions were removed from musl in d89fdec51b5849ebdf8000ff1c2fb49878004f39 but remained in our tree after the update. This fixes some strange failures we've been seeing on the CI builders where the name of a symbol alternates between __isxdigit_l (the new name) and isxdigit_l (the old name). This is due to the fact that this symbol was defined in two different object files and filesystem ordering was determining which object was included first by the linker. This change was automatically generated by checking out musl at v1.1.15 and running: `for f in $(find . -type f); do if [[ ! -e ../../../../../musl/$f ]]; then echo $f; fi; done | grep -v emscripten | xargs git rm`
|
I plan on landing this as TBR, assuming the tests pass since it should unblock the roller. |
sbc100
force-pushed
the
cleanup_old_musl_files
branch
from
946dcf3 to
0ea32cc
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When musl was updated to version 1.1.5 in #4813 it looks like files
that were removed upstream were not removed locally.
Because we recursively build some directories this means we were
build old files. For example the src/locale/is*.c family of functions
were removed from musl in d89fdec51b5849ebdf8000ff1c2fb49878004f39
but remained in our tree after the update.
This fixes some strange failures we've been seeing on the CI builders
where the name of a symbol alternates between __isxdigit_l (the new
name) and isxdigit_l (the old name). This is due to the fact that
this symbol was defined in two different object files and filesystem
ordering was determining which object was included first by the linker.
This change was automatically generated by checking out musl at v1.1.15
and running:
for f in $(find . -type f); do if [[ ! -e ../../../../../musl/$f ]]; then echo $f; fi; done | grep -v emscripten | xargs git rm