Fix emmalloc tests to allow a bit of slop #10183
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…kip emmalloc tests in LSan and ASan which do not support custom memory allocators.
juj
changed the title
Merged
kripken
approved these changes
Jan 10, 2020
|
Do we understand why the slop is needed? Aren't these tests fully deterministic? |
They should be - I don't currently know where the nondeterminism comes from. The heap is 16 bytes bigger to start with on some runs/systems. Marked down a note to investigate, but hopefully this PR lets the tot builder proceed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.