-
Notifications
You must be signed in to change notification settings - Fork 3.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Website does not show lists properly #21145
Comments
I'd be willing to attempt this, though I also don't have CSS skills, but I'd be willing to research and learn them. I did notice that the bullet points are shown correctly when you Preview the file in github: And I found the css file that seems to be applying that style here: I'm wondering though if that's a style that Emscripten has actually created? It looks like maybe it came from the Read The Docs software (it mentions the Sphinx theme from that software), and if there's an intentional reason for it? |
Good questions. From the history it looks like it appeared all at once 10 years ago, so I'd guess it was imported from a standard css file that maybe sphinx emits when one creates a new project? But I'm not sure. I think we can edit it to fix and improve things, or even replace it altogether if there is a better alternative. That is, there is no strong reason to keep using it right now, except that it exists and (mostly) works. If you can improve it that would be great, @adam4235 ! All options are open from my perspective: fixing it or replacing it, and we are not tied to the current look in any way. |
It's looking like I might not have time for this for now after all, so someone else can feel free to take it. |
@kripken |
Yes. Those should be bullet points.
The source code for the file I gave as an example is here: The CSS files are, I think, here: |
@kripken |
@kripken elements have property {list-style: none} which hides the bullet points. |
@kripten, Thank you for your valuable support! 🙌 |
Sounds promising! That could be exactly the fix we need. To test locally, you can go to After that you can view the website by running a local webserver, like |
For example, right under
The optimization level you should use depends mostly on the current stage of development:
on the optimizing code page we have this bulleted list:However, it does not show up as a list. I just see a paragraph for each of those. That is, there are no bullet points and the items are not indented by those bullet point markers (that should exist but do not).
I see this on both Firefox and Chrome, so it doesn't seem to be a browser issue. I also see that the HTML seems fine:
Using the devtools inspector I found we have
list-style: none
enabled in our CSS for some reason. Removing that "fixes" the issue, but then I see ugly unstyled dots for the bullet points, and they are not properly indented, so clearly that's not the right fix (which would be far beyond my CSS skills).The text was updated successfully, but these errors were encountered: