Skip to content

Fastcomp cleanup post removal #11860

Closed
Closed
@sbc100

Description

@sbc100

As a followup to #11319 we have a lot of potential cleanup of emscripten to do now that fastcomp is no more.

One thing to consider: do we want to make backporting/cherrying picking easy(er) for while). Should we hold off large refactors for a while for this reason? It seem like there will be enough pure-deletion PRs to keep us going for while :)

List of cleanup work:

  • Remove asmjs validation (Remove asmjs validation #11551).
  • Remove JS in src/ inside !WASM_BACKEND
  • Remove check_vanilla and is_vanilla cache file, @sbc
  • Remove all Python driver code inside not WASM_BACKEND
  • Remove WASM_BACKEND completely.
  • Remove fastcomp-only settings in settings.js.
  • Remove dual/split cache (cache/asmjs vs cache/wasm)
  • Remove fastcomp backend code in emscripten.py.
  • Remove WASM? (even with -s WASM=0 we set WASM to 1 and set WASM2JS, in verify_settings. so WASM == 1 all the time in tests etc.)

Cleanup PRs should mention "See #11860" (this PR).

Metadata

Metadata

Assignees

No one assigned

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions