You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Fix test runner warning caused by previous commit, and rename calculateDuration() to calculateElapsed() to avoid confusing/overloading similar terms. (#24402)
I removed the odd stub `addDuration()` function in the previous PR:
https://github.com/emscripten-core/emscripten/pull/24396/files#diff-fd5a5983b044aa841287bf197f2b5e46781162bf0e6a0ca8d1ccaddf1cc1c969L110-L111
turns out that Python unit test runner starts to warn if this function
is not present.
```
test_sse4 (test_core.strict_js.test_sse4) ... ok (1.14s)
C:\python\Lib\unittest\case.py:580: RuntimeWarning: TestResult has no addDuration method
warnings.warn("TestResult has no addDuration method",
test_sse4 (test_core.bigint.test_sse4) ... ok (1.10s)
C:\python\Lib\unittest\case.py:580: RuntimeWarning: TestResult has no addDuration method
warnings.warn("TestResult has no addDuration method",
test_sse4 (test_core.instance.test_sse4) ... ok (1.13s)
C:\python\Lib\unittest\case.py:580: RuntimeWarning: TestResult has no addDuration method
warnings.warn("TestResult has no addDuration method",
test_sse4 (test_core.core_2gb.test_sse4) ... ok (1.25s)
```
Add it back in, and use it to register the elapsed time in the test
(looks like Python internally tracks it).
Rename the `calculateDuration()` function to a `calculateElapsed()`
method so it doesn't look too similar to the `addDuration()` one.
0 commit comments