Fix chrome version test, and rename OLDEST_SUPPORTED_CHROME_VERSION to MIN_CHROME_VERSION

Author: juj

src/library_webgl.js

@@ -526,12 +526,13 @@ var LibraryGL = {
       webGLContextAttributes['preserveDrawingBuffer'] = true;
 #endif
 
-#if USE_WEBGL2 && OLDEST_SUPPORTED_CHROME_VERSION <= 57
+#if USE_WEBGL2 && MIN_CHROME_VERSION <= 57
       // BUG: Workaround Chrome WebGL 2 issue: the first shipped versions of WebGL 2 in Chrome did not actually implement the new WebGL 2 functions.
       //      Those are supported only in Chrome 58 and newer. For Chrome 57 (and older), disable WebGL 2 support altogether.
       function getChromeVersion() {
-        var raw = navigator.userAgent.match(/Chrom(e|ium)\/([0-9]+)\./);
-        return raw ? parseInt(raw[2], 10) : false;
+        var chromeVersion = navigator.userAgent.match(/Chrom(e|ium)\/([0-9]+)\./);
+        if (chromeVersion) return chromeVersion[2]|0;
+        // If not chrome, fall through to return undefined. (undefined <= integer will yield false)
       }
       if (getChromeVersion() <= 57) {
         WebGL2RenderingContext = undefined;

src/settings.js

@@ -488,11 +488,11 @@ var WORKAROUND_IOS_9_RIGHT_SHIFT_BUG = 0;
 // https://stackoverflow.com/questions/54248633/cannot-create-half-float-oes-texture-from-uint16array-on-ipad
 var GL_DISABLE_HALF_FLOAT_EXTENSION_IF_BROKEN = 0;
 
-// Specifies the oldest version of Chrome to target. E.g. a value -s OLDEST_SUPPORTED_CHROME_VERSION=58 would mean that Emscripten generates library code that would
+// Specifies the oldest version of Chrome to target. E.g. a value -s MIN_CHROME_VERSION=58 would mean that Emscripten generates library code that would
 // contain polyfills and backwards compatibility for Chrome >= 58 and newer. Set this to a small value to target old browsers, and to a high value to reduce code size
 // by dropping polyfill support for older browsers. Default to 0 to mean "all Chrome versions" (although in practice a large number of features require a specific much
 // newer Chrome version, e.g. Wasm or WebGL 2)
-var OLDEST_SUPPORTED_CHROME_VERSION = 0;
+var MIN_CHROME_VERSION = 0;
 
 // If set, enables polyfilling for Math.clz32, Math.trunc, Math.imul, Math.fround.
 var POLYFILL_OLD_MATH_FUNCTIONS = 0;

tests/test_other.py

@@ -9509,7 +9509,7 @@ def test_minimal_runtime_code_size(self):
                                '-s', 'GL_SUPPORT_EXPLICIT_SWAP_CONTROL=0',
                                '-s', 'GL_POOL_TEMP_BUFFERS=0',
                                '-s', 'FAST_UNROLLED_MEMCPY_AND_MEMSET=0',
-                               '-s', 'OLDEST_SUPPORTED_CHROME_VERSION=58',
+                               '-s', 'MIN_CHROME_VERSION=58',
                                '--output_eol', 'linux']
 
     asmjs = ['-s', 'WASM=0', '--separate-asm', '-s', 'ELIMINATE_DUPLICATE_FUNCTIONS=1', '--memory-init-file', '1']