Skip to content

Commit 78aa8ea

Browse files
authored
Restore and update metadce tests after LLVM and Binaryen rolls completed (#10283)
1 parent b728c8e commit 78aa8ea

6 files changed

+7
-10
lines changed

tests/other/metadce/hello_libcxx_O2_fexceptions.imports

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -40,6 +40,7 @@ invoke_viii
4040
invoke_viiii
4141
invoke_viiiiiii
4242
invoke_viiiiiiiiii
43+
invoke_viiiiiiiiiiiiiii
4344
memory
4445
setTempRet0
4546
strftime_l

tests/other/metadce/hello_libcxx_O2_fexceptions_DEMANGLE_SUPPORT.imports

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -40,6 +40,7 @@ invoke_viii
4040
invoke_viiii
4141
invoke_viiiiiii
4242
invoke_viiiiiiiiii
43+
invoke_viiiiiiiiiiiiiii
4344
memory
4445
setTempRet0
4546
strftime_l

tests/other/metadce/hello_world_O2.funcs

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,6 @@ $__growWasmMemory
66
$__overflow
77
$__stdio_write
88
$__towrite
9-
$__wasi_syscall_ret
109
$__wasm_call_ctors
1110
$dlfree
1211
$dlmalloc

tests/other/metadce/hello_world_Os.funcs

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,6 @@ $__fwritex
44
$__overflow
55
$__stdio_write
66
$__towrite
7-
$__wasi_syscall_ret
87
$__wasm_call_ctors
98
$fwrite
109
$main

tests/other/metadce/hello_world_Oz.funcs

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,6 @@ $__fwritex
44
$__overflow
55
$__stdio_write
66
$__towrite
7-
$__wasi_syscall_ret
87
$__wasm_call_ctors
98
$fwrite
109
$main

tests/test_other.py

Lines changed: 5 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -8206,13 +8206,12 @@ def test_metadce_minimal_fastcomp(self, *args):
82068206
@parameterized({
82078207
'noexcept': (['-O2'], 19, [], ['waka'], 218988, 17, 33, None), # noqa
82088208
# exceptions increases code size significantly
8209-
'except': (['-O2', '-fexceptions'], 52, [], ['waka'], 279827, 46, 46, None), # noqa
8209+
'except': (['-O2', '-fexceptions'], 52, [], ['waka'], 279827, 47, 46, None), # noqa
82108210
# exceptions does not pull in demangling by default, which increases code size
82118211
'mangle': (['-O2', '-fexceptions',
8212-
'-s', 'DEMANGLE_SUPPORT'], 52, [], ['waka'], 408028, 46, 47, None), # noqa
8212+
'-s', 'DEMANGLE_SUPPORT'], 52, [], ['waka'], 408028, 47, 47, None), # noqa
82138213
})
82148214
@no_fastcomp()
8215-
@unittest.skip("Allow LLVM roll to proceed")
82168215
def test_metadce_cxx(self, *args):
82178216
# test on libc++: see effects of emulated function pointers
82188217
self.run_metadce_test('hello_libcxx.cpp', *args)
@@ -8231,10 +8230,10 @@ def test_metadce_cxx_fastcomp(self, *args):
82318230
@parameterized({
82328231
'O0': ([], 10, [], ['waka'], 22874, 9, 18, 58), # noqa
82338232
'O1': (['-O1'], 7, [], ['waka'], 10415, 6, 14, 30), # noqa
8234-
'O2': (['-O2'], 7, [], ['waka'], 10256, 6, 14, 25), # noqa
8233+
'O2': (['-O2'], 7, [], ['waka'], 10256, 6, 14, 24), # noqa
82358234
'O3': (['-O3'], 4, [], [], 1957, 4, 2, 12), # noqa; in -O3, -Os and -Oz we metadce
8236-
'Os': (['-Os'], 4, [], [], 1963, 4, 2, 13), # noqa
8237-
'Oz': (['-Oz'], 4, [], [], 2031, 4, 2, 13), # noqa
8235+
'Os': (['-Os'], 4, [], [], 1963, 4, 2, 12), # noqa
8236+
'Oz': (['-Oz'], 4, [], [], 2031, 4, 2, 12), # noqa
82388237
# finally, check what happens when we export nothing. wasm should be almost empty
82398238
'export_nothing':
82408239
(['-Os', '-s', 'EXPORTED_FUNCTIONS=[]'],
@@ -8246,7 +8245,6 @@ def test_metadce_cxx_fastcomp(self, *args):
82468245
'main_module_2': (['-O3', '-s', 'MAIN_MODULE=2'], 12, [], [], 10652, 12, 10, None), # noqa
82478246
})
82488247
@no_fastcomp()
8249-
@unittest.skip("Allow LLVM roll to proceed")
82508248
def test_metadce_hello(self, *args):
82518249
self.run_metadce_test('hello_world.cpp', *args)
82528250

0 commit comments

Comments
 (0)