Skip to content

Commit 5403790

Browse files
authored
Accept minor code size regressions after LLVM update (#13936)
LLVM change: llvm/llvm-project@9423f78 That uses unsigned operations in more places. Those are less size-efficient than signed ones in wasm2js, so unfortunately this increases code size there. I do not see a simple way to optimize things better in wasm2js - the LLVM change just switches to an unsigned operation, but then that gets taken into account in later work - apparently sometimes helpful, hence the change - and the result is not a simple unsigned operation we can replace easily.
1 parent b78a631 commit 5403790

File tree

4 files changed

+12
-12
lines changed

4 files changed

+12
-12
lines changed

tests/code_size/hello_webgl2_wasm2js.json

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -2,9 +2,9 @@
22
"a.html": 588,
33
"a.html.gz": 386,
44
"a.js": 19947,
5-
"a.js.gz": 8158,
5+
"a.js.gz": 8160,
66
"a.mem": 3171,
77
"a.mem.gz": 2715,
88
"total": 23706,
9-
"total_gz": 11259
9+
"total_gz": 11261
1010
}

tests/code_size/hello_webgl_wasm2js.json

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -2,9 +2,9 @@
22
"a.html": 588,
33
"a.html.gz": 386,
44
"a.js": 19429,
5-
"a.js.gz": 7990,
5+
"a.js.gz": 7995,
66
"a.mem": 3171,
77
"a.mem.gz": 2715,
88
"total": 23188,
9-
"total_gz": 11091
9+
"total_gz": 11096
1010
}
Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
{
2-
"a.html": 12589,
3-
"a.html.gz": 6771,
4-
"total": 12589,
5-
"total_gz": 6771
2+
"a.html": 12609,
3+
"a.html.gz": 6781,
4+
"total": 12609,
5+
"total_gz": 6781
66
}
Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
{
2-
"a.html": 17332,
3-
"a.html.gz": 7453,
4-
"total": 17332,
5-
"total_gz": 7453
2+
"a.html": 17370,
3+
"a.html.gz": 7492,
4+
"total": 17370,
5+
"total_gz": 7492
66
}

0 commit comments

Comments
 (0)