Support for websockets & minor changes #119
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The test was broken in commit 420db41 because it introduced a 2bit bitfield to store the QoS. The unit tests on QMQTT::Message assumed it was possible to store a QoS of 5, which does not fit in the bitfield.
This feature will only be compiled if explicitly enabled: qmake CONFIG+=QMQTT_WEBSOCKETS or: qbs build qmqtt.webSocketSupport:true There are 2 reasons: * websocket support relies on the QWebsocket class which is part of the websockets module. Previous versions of qmqtt did not rely on this module, so it may not be present on systems where old versions of the shared library are in use. Adding a new module dependency will make it harder to upgrade this systems. * A call to QWebSocket::open(const QNetworkRequest &) is used, which was introduced in Qt 5.6. qmqtt itself requires version 5.3 or newer.
|
Very good work @ejvr ! |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
QWebSocket::openfunction which was added in this version. Websocket support is disabled by default (because is requires the QT websockets module which may not always be present). The readme has info on how to enable support. I have only tested this with the EMQ broker.