Skip to content

Conversation

@thalesmg
Copy link
Contributor

@thalesmg thalesmg commented Oct 22, 2025

Part of https://emqx.atlassian.net/browse/EMQX-14804

Release version: 6.1.0

Summary

PR Checklist

  • For internal contributor: there is a jira ticket to track this change
  • The changes are covered with new or existing tests
  • Change log for changes visible by users has been added to changes/ee/(feat|perf|fix|breaking)-<PR-id>.en.md files
  • Schema changes are backward compatible or intentionally breaking (describe the changes and the reasoning in the summary)

Previously, these were in `emqx_conf`.  However, we'll need to call those functions in
`emqx_schema` and `emqx_tls_lib`, which reside in the `emqx` application, a dependency of
`emqx_conf`.
@thalesmg thalesmg force-pushed the 20251022-m-tls-central-ssl-opts branch 8 times, most recently from 0c89664 to 92e06af Compare October 24, 2025 18:35
The `ssl_file_deterministic_names_test` was not actually being run, because `eunit`
requires it to be a generator function rather than a plain test.
@thalesmg thalesmg force-pushed the 20251022-m-tls-central-ssl-opts branch from 92e06af to 57ff3d7 Compare October 24, 2025 19:28
@codecov-commenter
Copy link

Codecov Report

❌ Patch coverage is 91.35802% with 7 lines in your changes missing coverage. Please review.
✅ Project coverage is 84.70%. Comparing base (1888051) to head (57ff3d7).
⚠️ Report is 22 commits behind head on master.

Files with missing lines Patch % Lines
apps/emqx/src/emqx_tls_lib.erl 92.00% 4 Missing ⚠️
apps/emqx/src/emqx_managed_certs.erl 75.00% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master   #16154      +/-   ##
==========================================
- Coverage   84.74%   84.70%   -0.04%     
==========================================
  Files        1155     1155              
  Lines       79830    79893      +63     
==========================================
+ Hits        67648    67675      +27     
- Misses      12182    12218      +36     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@thalesmg thalesmg marked this pull request as ready for review October 27, 2025 12:09
@thalesmg thalesmg requested a review from a team as a code owner October 27, 2025 12:09
Co-authored-by: zmstone <zmstone@gmail.com>
@thalesmg
Copy link
Contributor Author

CI test failures unrelated to changes herein: github.com//pull/16166

@thalesmg thalesmg merged commit fa43705 into emqx:master Oct 27, 2025
149 of 150 checks passed
@thalesmg thalesmg deleted the 20251022-m-tls-central-ssl-opts branch October 27, 2025 18:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants