Skip to content

update(Kinesis): Add health check interval jitter config #3069

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 9 commits into
base: release-6.0
Choose a base branch
from

Conversation

Meggielqk
Copy link
Collaborator

@Meggielqk Meggielqk added this to the 6.0.0 milestone Jul 9, 2025
@Meggielqk
Copy link
Collaborator Author

The default value for the health check interval jitter config is 15 second for Kinesis, while it is 0 millisecond for other Sinks on Dashboard. Are there any reason for the difference? @thalesmg

@Meggielqk Meggielqk marked this pull request as ready for review July 10, 2025 07:17
@Meggielqk Meggielqk requested a review from thalesmg July 10, 2025 07:17
@thalesmg
Copy link
Contributor

The default value for the health check interval jitter config is 15 second for Kinesis, while it is 0 millisecond for other Sinks on Dashboard. Are there any reason for the difference? @thalesmg

It's basically this comment, plus the behavior described in the changelog that introduced it:

If they receive a throttling response (e.g.: LimitExceededException), they will also maintain their current status.

In other words, if there's throttling from Kinesis and some actions are in the disconnected state, and if these disconnected actions keep firing their health checks after others under the same connector, they will not change their status. Jitter adds a random delay so that, eventually, these disconnected actions have the chance of running before others and hopefully switch to connected.

@Meggielqk
Copy link
Collaborator Author

chance

Thank you for the answer. Could you please verify if the description for this config is correct?

@Meggielqk Meggielqk requested a review from id July 15, 2025 09:15
@thalesmg
Copy link
Contributor

Thank you for the answer. Could you please verify if the description for this config is correct?

This comments seems to still be in the field description:

This helps avoid burst traffic, reduces the risk of triggering downstream rate limits (e.g., API throttling), and improves system stability.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants