Skip to content

Conversation

@rtablada
Copy link

Right now it's fairly reasonable for people to remove some of the pre-baked content without replacing it. When pushed and cloned by another dev or run in CI, this would cause an error because the different folders are not found. These .gitkeep files make sure the directories don't go missing when users delete the starter content.

@mansona
Copy link
Member

mansona commented Mar 3, 2021

so I think this is a potential solution to the problem for sure... but I think the more fundamental issue is that it errors if the folders are not found 🤔 what if we just made them optional? because there is a chance that people will either not commit the .gitkeep because they don't know why it's there or they might delete the folder including the .gitkeep file

what do you think?

@elwayman02
Copy link
Contributor

I think if you can make it not error for any directory that isn't actually required, that would be A+. Though I think you could maybe file that as an issue and still merge this as a short-term fix? Unless it's something you plan on tackling immediately, of course.

@mansona
Copy link
Member

mansona commented Mar 5, 2021

So I did get this done pretty quickly: #112

The thing is, it might make sense to delete the page folder and you can just about get away with deleting the tag folder.... but it doesn't make sense to delete the content or the author folders so those gitkeeps don't make too much sense 🤔 what do you both think?

@elwayman02
Copy link
Contributor

I think that there are valid scenarios where someone might try to deploy (or at least build) the app without files in the content or author directories. I've expanded on that in your PR here: #112 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants