Skip to content

Conversation

pvdstel
Copy link
Contributor

@pvdstel pvdstel commented Oct 12, 2022

What: adds the -ms-expand and -ms-reveal to ignored vendor prefixes; similar to #2393.

Why: browsers that do not support these vendor prefixes (i.e. Chrome and Firefox) will cause error messages to be displayed in the console. The prefixes themselves are fairly common:

  • -ms-expand is used to hide the browser's dropdown arrow when styling select elements, in Internet Explorer, Edge (both old and Chromium-based). This pseudo element is also used in MUI Core.
  • -ms-reveal is often used to hide the password reveal button, in password inputs. This pseudo-element selector works in IE10+ and in Edge browsers as well.

How: the pseudo-elements were added to the the regex of selectors for which no error is emitted.

Checklist:

  • Documentation (N/A ; there does not seem to exist any documentation on this)
  • Tests (N/A ; there seem to be no existing tests for this, and I'm not sure how to properly test this in the first place)
  • Code complete
  • Changeset

@changeset-bot
Copy link

changeset-bot bot commented Oct 12, 2022

🦋 Changeset detected

Latest commit: e400b5b

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@emotion/sheet Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@codesandbox-ci
Copy link

codesandbox-ci bot commented Oct 12, 2022

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit e400b5b:

Sandbox Source
Emotion Configuration

@codecov
Copy link

codecov bot commented Oct 12, 2022

Codecov Report

Merging #2920 (15d0d0a) into main (8a16374) will not change coverage.
The diff coverage is 100.00%.

❗ Current head 15d0d0a differs from pull request most recent head e400b5b. Consider uploading reports for the commit e400b5b to get more accurate results

Impacted Files Coverage Δ
packages/sheet/src/index.js 100.00% <100.00%> (ø)

@Andarist Andarist merged commit 61c6696 into emotion-js:main Oct 12, 2022
@github-actions github-actions bot mentioned this pull request Oct 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants