Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade Yarn #2870

Merged
merged 1 commit into from
Aug 29, 2022
Merged

Upgrade Yarn #2870

merged 1 commit into from
Aug 29, 2022

Conversation

Andarist
Copy link
Member

No description provided.

@Andarist Andarist requested a review from srmagura August 29, 2022 11:16
@changeset-bot
Copy link

changeset-bot bot commented Aug 29, 2022 •
edited
Loading

⚠️ No Changeset found

Latest commit: 29c3d27

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@Andarist Andarist marked this pull request as ready for review August 29, 2022 11:17
Andarist
Andarist commented Aug 29, 2022
View reviewed changes
package.json
@@ -23,7 +23,7 @@
"preinstall": "node ./scripts/ensure-yarn.js",
"postinstall": "preconstruct dev && manypkg check",
"changeset": "changeset",
"version-packages": "changeset version && yarn --no-immutable",
"version-packages": "changeset version && yarn --mode=\"update-lockfile\"",
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It has been suggested as the faster/better option for this use case (which still isn't 100% safe as it could potentially change unrelated sections of the lockfile but there is no solution for this problem)

Andarist
Andarist commented Aug 29, 2022
View reviewed changes
package.json
@@ -244,7 +244,7 @@
"unified": "^6.1.6",
"webpack-bundle-analyzer": "3.3.2"
},
"packageManager": "yarn@3.2.2",
"packageManager": "yarn@3.2.3",
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is supposed to fix our patch not being correctly applied. Note that the patch itself could be removed if we'd upgrade Jest.

@codesandbox-ci
Copy link

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 29c3d27:

Sandbox Source
Emotion Configuration

@Andarist Andarist merged commit 28522cd into main Aug 29, 2022
@Andarist Andarist deleted the upgrade-yarn branch August 29, 2022 14:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@srmagura srmagura srmagura approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Andarist @srmagura