Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed a regression that could cause a crash when looking for an ignoring comment for unsafe pseudo-classes #2864

Merged
merged 2 commits into from
Aug 23, 2022

Conversation

Andarist
Copy link
Member

fixes #2863

@changeset-bot
Copy link

changeset-bot bot commented Aug 23, 2022

🦋 Changeset detected

Latest commit: 0a7f898

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@emotion/cache Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@codesandbox-ci
Copy link

codesandbox-ci bot commented Aug 23, 2022

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 0a7f898:

Sandbox Source
Emotion Configuration

@@ -184,7 +307,7 @@ describe('unsafe pseudo classes', () => {
expect(console.error).not.toBeCalled()
})

test.only('does not warn when using the flag on the rule that preceeds a declaration', () => {
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My bad - I forgot to uncomment this and I've missed broken cases (tests added as part of this PR are new though, the crash didn't occur in the existing test suite but some expectations around those warnings were broken)

@codecov
Copy link

codecov bot commented Aug 23, 2022

Codecov Report

Merging #2864 (0a7f898) into main (df434ea) will increase coverage by 1.05%.
The diff coverage is 100.00%.

Impacted Files Coverage Δ
packages/cache/src/stylis-plugins.js 99.12% <100.00%> (+13.03%) ⬆️
packages/react/src/class-names.js 100.00% <0.00%> (+2.89%) ⬆️
packages/react/src/global.js 98.24% <0.00%> (+3.50%) ⬆️
packages/serialize/src/index.js 100.00% <0.00%> (+6.01%) ⬆️

@Andarist Andarist merged commit b9b8b74 into main Aug 23, 2022
@Andarist Andarist deleted the fix/2863 branch August 23, 2022 16:53
@github-actions github-actions bot mentioned this pull request Aug 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Emotion/Cache throws exeption with newest patch version (related to #2751)
1 participant