Stylis upgrade (#2590)

* Upgrade to stylis@4.0.11 * Upgrade to stylis@4.0.12 * Drop `@supports` and `@media` special cases from the compat plugin * add changeset * Upgrade to stylis@4.0.13
emotion-js · Dec 12, 2021 · 1554a7e · 1554a7e
1 parent 04681a5
commit 1554a7e
Show file tree

Hide file tree

Showing 7 changed files with 21 additions and 10 deletions.
diff --git a/.changeset/slow-planes-impress.md b/.changeset/slow-planes-impress.md
@@ -0,0 +1,10 @@
+---
+'@emotion/babel-plugin': patch
+'@emotion/cache': patch
+'@emotion/css': patch
+'@emotion/css-prettifier': patch
+'@emotion/jest': patch
+'@emotion/react': patch
+---
+
+Upgraded and pinned the version of Stylis - the CSS parser that Emotion uses under the hood.
diff --git a/packages/babel-plugin/package.json b/packages/babel-plugin/package.json
@@ -24,7 +24,7 @@
     "escape-string-regexp": "^4.0.0",
     "find-root": "^1.1.0",
     "source-map": "^0.5.7",
-    "stylis": "^4.0.10"
+    "stylis": "4.0.13"
   },
   "peerDependencies": {
     "@babel/core": "^7.0.0"

diff --git a/packages/cache/package.json b/packages/cache/package.json
@@ -19,7 +19,7 @@
     "@emotion/sheet": "^1.1.0",
     "@emotion/utils": "^1.0.0",
     "@emotion/weak-memoize": "^0.2.5",
-    "stylis": "^4.0.10"
+    "stylis": "4.0.13"
   },
   "devDependencies": {
     "@emotion/hash": "*",

diff --git a/packages/cache/src/stylis-plugins.js b/packages/cache/src/stylis-plugins.js
@@ -89,8 +89,9 @@ export let compat = element => {
   if (
     element.type !== 'rule' ||
     !element.parent ||
-    // .length indicates if this rule contains pseudo or not
-    !element.length
+    // positive .length indicates that this rule contains pseudo
+    // negative .length indicates that this rule has been already prefixed
+    element.length < 1
   ) {
     return
   }

diff --git a/packages/css-prettifier/package.json b/packages/css-prettifier/package.json
@@ -16,7 +16,7 @@
   "repository": "https://github.com/emotion-js/emotion/tree/main/packages/css-prettifier",
   "dependencies": {
     "@emotion/memoize": "^0.7.4",
-    "stylis": "^4.0.10"
+    "stylis": "4.0.13"
   },
   "devDependencies": {},
   "publishConfig": {

diff --git a/packages/jest/package.json b/packages/jest/package.json
@@ -21,7 +21,7 @@
     "@emotion/css-prettifier": "^1.0.0",
     "chalk": "^4.1.0",
     "specificity": "^0.4.1",
-    "stylis": "^4.0.10"
+    "stylis": "4.0.13"
   },
   "peerDependencies": {
     "@types/jest": "^26.0.14 || ^27.0.0",

diff --git a/yarn.lock b/yarn.lock
@@ -28143,10 +28143,10 @@ stylis@3.5.4:
   resolved "https://registry.yarnpkg.com/stylis/-/stylis-3.5.4.tgz#f665f25f5e299cf3d64654ab949a57c768b73fbe"
   integrity sha512-8/3pSmthWM7lsPBKv7NXkzn2Uc9W7NotcwGNpJaa3k7WMM1XDCA4MgT5k/8BIexd5ydZdboXtU90XH9Ec4Bv/Q==
 
-stylis@^4.0.10:
-  version "4.0.10"
-  resolved "https://registry.yarnpkg.com/stylis/-/stylis-4.0.10.tgz#446512d1097197ab3f02fb3c258358c3f7a14240"
-  integrity sha512-m3k+dk7QeJw660eIKRRn3xPF6uuvHs/FFzjX3HQ5ove0qYsiygoAhwn5a3IYKaZPo5LrYD0rfVmtv1gNY1uYwg==
+stylis@4.0.13:
+  version "4.0.13"
+  resolved "https://registry.yarnpkg.com/stylis/-/stylis-4.0.13.tgz#f5db332e376d13cc84ecfe5dace9a2a51d954c91"
+  integrity sha512-xGPXiFVl4YED9Jh7Euv2V220mriG9u4B2TA6Ybjc1catrstKD2PpIdU3U0RKpkVBC2EhmL/F0sPCr9vrFTNRag==
 
 sudo-prompt@^8.2.0:
   version "8.2.5"