Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Some onEquip/onUnequip calls within the inventory screen is not processed on the logical server #225

Open
MrEluzium opened this issue Dec 7, 2022 · 0 comments
Open

Some onEquip/onUnequip calls within the inventory screen is not processed on the logical server #225

MrEluzium opened this issue Dec 7, 2022 · 0 comments

Comments

@MrEluzium
Copy link

I ran into a problem while developing mod that depends on trinkets.
Basic mechanics are based on updating players that wearing trinket, and I tried to implement that using onEquip/onUnequip calls.
The bug appears when I try to get trinket out of the slot repeatedly.

Here is reproduction with some debug logging in LivingEntityMixin class and Copper Rings mod by ZeroKun265.

image

Server don't know that player don't have ring in slot after first onUnequip call.
Temporary solution is send a packet from client to server with onUnequip call every time it happens on client side.

Info:
Trinkets version: 3.4.1
Minecraft version: 1.19 (originally I found this bug on 1.19.2)
MrEluzium added a commit to MrEluzium/Linkage that referenced this issue Dec 8, 2022
@MrEluzium
Fixed available players list update on logical server
15c118e 
Now onEquip and onUnequip process only on client due to this issue: emilyploszaj/trinkets#225
Sometimes server misses these events and players stays in available list, although they should be removed
To avoid this, we tell server to update available list every time client get onEquip or onUnequip call
MrEluzium added a commit to MrEluzium/Linkage that referenced this issue Dec 11, 2022
@MrEluzium
Fixed available players list update on logical server
5b1c1f8 
Now onEquip and onUnequip process only on client due to this issue: emilyploszaj/trinkets#225
Sometimes server misses these events and players stays in available list, although they should be removed
To avoid this, we tell server to update available list every time client get onEquip or onUnequip call
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@MrEluzium