Repository navigation
Conversation
When using a system/distribution-provided Widevine CDM (e.g. Debian/Raspberry Pi OS libwidevinecdm0 package where cdm_from_repo() is True), the manifest.json does not contain ChromeOS-specific 'accept_arch', 'platforms', or 'arch' keys. In this case, load_widevine_config() returns a dict without arch info and wv_config_arch resolves to None. Evaluating `... not in None` raised: TypeError: argument of type 'NoneType' is not iterable Add a null check so that architecture verification is safely skipped when no arch metadata is present in the manifest.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When using a system/distribution-provided Widevine CDM (e.g. Debian/Raspberry Pi OS libwidevinecdm0 package where cdm_from_repo() is True), the manifest.json does not contain ChromeOS-specific 'accept_arch', 'platforms', or 'arch' keys. In this case, load_widevine_config() returns a dict without arch info and wv_config_arch resolves to None. Evaluating
... not in Noneraised:TypeError: argument of type 'NoneType' is not iterable
Add a null check so that architecture verification is safely skipped when no arch metadata is present in the manifest.