Skip to content

Fix BoxPlot legend #97

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
lucasmerlin merged 4 commits into from
Jul 11, 2025
Merged

Fix BoxPlot legend #97

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
9883651
Fix use of PlotItemBase in BoxPlot and BarChart
mkalte666 Apr 7, 2025
b1c1b75
Merge branch 'main' into boxplot_legend
lucasmerlin Jul 11, 2025
195154a
Revert breaking default_color name change
lucasmerlin Jul 11, 2025
4ab9db0
Revert breaking default_color name change for BoxPlot
lucasmerlin Jul 11, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 2 additions & 8 deletions egui_plot/src/items/mod.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1304,7 +1304,7 @@ pub struct BarChart {
base: PlotItemBase,

pub(super) bars: Vec<Bar>,
pub(super) default_color: Color32,
default_color: Color32,

/// A custom element formatter
pub(super) element_formatter: Option<Box<dyn Fn(&Bar, &BarChart) -> String>>,
Expand Down Expand Up @@ -1463,8 +1463,7 @@ pub struct BoxPlot {
base: PlotItemBase,

pub(super) boxes: Vec<BoxElem>,
pub(super) default_color: Color32,
pub(super) name: String,
default_color: Color32,

/// A custom element formatter
pub(super) element_formatter: Option<Box<dyn Fn(&BoxElem, &BoxPlot) -> String>>,
Expand All @@ -1477,7 +1476,6 @@ impl BoxPlot {
base: PlotItemBase::new(name.into()),
boxes,
default_color: Color32::TRANSPARENT,
name: String::new(),
element_formatter: None,
}
}
Expand Down Expand Up @@ -1543,10 +1541,6 @@ impl PlotItem for BoxPlot {
// nothing to do
}

fn name(&self) -> &str {
self.name.as_str()
}

fn color(&self) -> Color32 {
self.default_color
}
Expand Down
4 changes: 2 additions & 2 deletions egui_plot/src/plot_ui.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -238,7 +238,7 @@ impl<'a> PlotUi<'a> {
}

// Give the elements an automatic color if no color has been assigned.
if box_plot.default_color == Color32::TRANSPARENT {
if PlotItem::color(&box_plot) == Color32::TRANSPARENT {
box_plot = box_plot.color(self.auto_color());
}
self.items.push(Box::new(box_plot));
Expand All @@ -251,7 +251,7 @@ impl<'a> PlotUi<'a> {
}

// Give the elements an automatic color if no color has been assigned.
if chart.default_color == Color32::TRANSPARENT {
if PlotItem::color(&chart) == Color32::TRANSPARENT {
chart = chart.color(self.auto_color());
}
self.items.push(Box::new(chart));
Expand Down
Loading